Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handle negative goal distance #131

Merged
merged 1 commit into from
Nov 5, 2024
Merged

add handle negative goal distance #131

merged 1 commit into from
Nov 5, 2024

Conversation

tkhmy
Copy link
Contributor

@tkhmy tkhmy commented Nov 1, 2024

Related Issue(required)

Description(required)

  • ignore announcement when the goal distance is negative

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

@tkhmy tkhmy requested a review from yabuta November 1, 2024 08:41
Copy link
Collaborator

@yabuta yabuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkhmy tkhmy merged commit b3570c3 into develop Nov 5, 2024
0 of 2 checks passed
tkhmy added a commit that referenced this pull request Nov 5, 2024
tkhmy added a commit that referenced this pull request Nov 5, 2024
tkhmy added a commit that referenced this pull request Nov 5, 2024
yabuta pushed a commit that referenced this pull request Nov 5, 2024
tkhmy added a commit that referenced this pull request Nov 5, 2024
* Fix/seperate fms client (#130)

* seperate fms client

Signed-off-by: tkhmy <[email protected]>

* add ignore disconnect

Signed-off-by: tkhmy <[email protected]>

* remove some colcon build warning

Signed-off-by: tkhmy <[email protected]>

* change naming

Signed-off-by: tkhmy <[email protected]>

* change time out, minor fix

Signed-off-by: tkhmy <[email protected]>

* remove old logger

Signed-off-by: tkhmy <[email protected]>

* fix

Signed-off-by: tkhmy <[email protected]>

---------

Signed-off-by: tkhmy <[email protected]>

* add handle negative goal distance (#131)

Signed-off-by: tkhmy <[email protected]>

* fix package

Signed-off-by: tkhmy <[email protected]>

---------

Signed-off-by: tkhmy <[email protected]>
yabuta added a commit that referenced this pull request Nov 5, 2024
* Fix/seperate fms client (#130)

* seperate fms client

Signed-off-by: tkhmy <[email protected]>

* add ignore disconnect

Signed-off-by: tkhmy <[email protected]>

* remove some colcon build warning

Signed-off-by: tkhmy <[email protected]>

* change naming

Signed-off-by: tkhmy <[email protected]>

* change time out, minor fix

Signed-off-by: tkhmy <[email protected]>

* remove old logger

Signed-off-by: tkhmy <[email protected]>

* fix

Signed-off-by: tkhmy <[email protected]>

---------

Signed-off-by: tkhmy <[email protected]>

* add handle negative goal distance (#131)

Signed-off-by: tkhmy <[email protected]>

---------

Signed-off-by: tkhmy <[email protected]>
Co-authored-by: Kah Hooi Tan <[email protected]>
tkhmy added a commit that referenced this pull request Nov 8, 2024
* Fix/seperate fms client (#130)

* seperate fms client

Signed-off-by: tkhmy <[email protected]>

* add ignore disconnect

Signed-off-by: tkhmy <[email protected]>

* remove some colcon build warning

Signed-off-by: tkhmy <[email protected]>

* change naming

Signed-off-by: tkhmy <[email protected]>

* change time out, minor fix

Signed-off-by: tkhmy <[email protected]>

* remove old logger

Signed-off-by: tkhmy <[email protected]>

* fix

Signed-off-by: tkhmy <[email protected]>

---------

Signed-off-by: tkhmy <[email protected]>

* add handle negative goal distance (#131)

Signed-off-by: tkhmy <[email protected]>

* fix the hash code

Signed-off-by: tkhmy <[email protected]>

---------

Signed-off-by: tkhmy <[email protected]>
tkhmy added a commit that referenced this pull request Nov 21, 2024
@tkhmy tkhmy mentioned this pull request Nov 21, 2024
8 tasks
tkhmy added a commit that referenced this pull request Nov 21, 2024
* add fms handler

Signed-off-by: tkhmy <[email protected]>

* add handle negative goal distance (#131)

Signed-off-by: tkhmy <[email protected]>

* modify sound of emergency stop

* modify signage outlook

* update hash

Signed-off-by: tkhmy <[email protected]>

---------

Signed-off-by: tkhmy <[email protected]>
Co-authored-by: Shohei Sakai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants